Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pulling private GitHub repos for Neurohackademy #2852

Merged

Conversation

sgibson91
Copy link
Member

Following instructions in #2849 as an alternative for authenticated static sites

new hub issue: #2681

I reused the same GitHub App that I had previously set up for the static site and is already installed on the appropriate repo.

@sgibson91 sgibson91 requested a review from a team as a code owner July 21, 2023 09:34
@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp 2i2c No Yes Following prod hubs require redeploy: neurohackademy

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
gcp 2i2c neurohackademy Following helm chart values files were modified: enc-neurohackademy.secret.values.yaml, neurohackademy.values.yaml

Copy link
Contributor

@pnasrat pnasrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Required to bring in version of the image with git-credentials-helper installed
@sgibson91
Copy link
Member Author

I am holding off on merging this as nbgitpuller is returning a 128 error status

@yuvipanda
Copy link
Member

I figured out why this isn't working! Updated the docs PR, at ac2ad97.

Basically, because in the image, git is installed via conda, it doesn't read /etc/gitconfig. Looks like someone (:D) filed an issue about this in the conda feedstock that's unfortunately still not fixed (conda-forge/git-feedstock#113).

in this case, $CONDA_PREFIX is /srv/conda/envs/notebook, so the path should be /srv/conda/envs/notebook/etc/gitconfig. I can't make a suggestion here because of sops though.

@sgibson91
Copy link
Member Author

Booooo! (Let me push the commit that generated this)

2023-07-21T16:57:09Z [Warning] Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/var/lib/kubelet/pods/8b096c8a-84e4-4bee-b35c-18e9025c7c4e/volume-subpaths/files/notebook/2" to rootfs at "/srv/conda/envs/notebook/etc/gitconfig/github-app-private-key.pem": open o_path procfd: open /run/containerd/io.containerd.runtime.v2.task/k8s.io/notebook/rootfs/srv/conda/envs/notebook/etc/gitconfig/github-app-private-key.pem: not a directory: unknown

@sgibson91
Copy link
Member Author

No wait, I think I've just done the wrong thing.. hang on

@sgibson91
Copy link
Member Author

Cracked it!

Git has been installed using conda-forge, and so has a ${CONDA_PREFIX}
@sgibson91 sgibson91 merged commit e94a9ae into 2i2c-org:master Jul 21, 2023
@sgibson91 sgibson91 deleted the neurohackademy/private-nbgitpuller branch July 21, 2023 17:07
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/5624822878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants