Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on enabling pulling from private GitHub repos #2849

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

yuvipanda
Copy link
Member

We already have this enabled for UToronto, just not documented.

Ref #2848

We already have this enabled for UToronto, just not documented.

Ref 2i2c-org#2848
```

Use the app-id of the GitHub app you just created. This goes in the hub's
`values.yaml` file. If used for a `daskhub`, next the whole thing under a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`values.yaml` file. If used for a `daskhub`, next the whole thing under a
`values.yaml` file. If used for a `daskhub`, nest the whole thing under a

sgibson91 added a commit to sgibson91/infrastructure that referenced this pull request Jul 21, 2023
Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty good! A couple of clarifying comments. I also only really did the helm chart values part because I had already set up a GitHub App for the static site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants