Personalize callysto singleuser server page #1710
Conversation
| @@ -32,6 +32,28 @@ jupyterhub: | |||
| image: | |||
| name: callysto/2i2c | |||
| tag: 0.1.0 | |||
| extraFiles: | |||
| tree.html: | |||
There was a problem hiding this comment.
Normally, extending only the page.html template would have been enough since both the tree and the notebook templates are extending it themselves. But for some reason, it turned impossible to make it to work like this... I fear this is because of NotebookApp -> ServerApp? But I have tried everything with no luck, so this is the best version that's actually doing the job
| <style> | ||
| .clusters_tab_link { | ||
| visibility: hidden; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Hmm, actually this one is only possible in "tree.html", so we would have needed two templates anyway
| NotebookApp: | ||
| extra_template_paths: | ||
| - /usr/local/share/jupyter/custom_template |
There was a problem hiding this comment.
I'm setting this one in the basehub template because it does no harm if we set it here and we provide no custom templates.
The benefit of this being here is that we can inject extraFiles for other hubs too to extend the templates if need be in the future.
Or at least until will decide on a better strategy as part of #1697 that might imply sync-ing the templates from a repo on the fly like we do with the hub templates.
|
Thanks for the feedback @sgibson91, @damianavila!
@damianavila , I don't think it has to do with user image, but it's instead a separate thing. And I agree this should be a feature that could be customized by the community instead of us (similar to the hub templates customization). I suggest sharing any thoughts about possible ways to implement this in a more sustainable way, in #1697 and consider this an workaround until a clear path forward arises from #1697. WDYT? In the meantime I will merge this since I have an approval and want to ship this for callysto as promised. But feel free to revert or share any other thoughts about the implementation specifics in #1697. Thanks! |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/3142112735 |
I understand, thanks for re-raising that point. I think it is a good compromise (you may notice I did not actually request changes to the PR, I just dropped a general opinion).
LGTM, I will reference my comment on that issue!
No need to revert anything! Thanks again for working on this. |
This uses the
singleuser.extraFilesconfig to add a custom logo for the singleuser server dashboard and notebook, i.e. the Callysto one and hides theClusterstab from the dashboard.The Hub interface has been customized too through the https://github.com/2i2c-org/default-hub-homepage/tree/callysto-staging, but only for the staging hub at the moment. I will add a new branch
callysto-prodto override the prod hub also.Closes #1439
Note that I will leave a couple of comments in the code to explain some of the assumptions/compromises I've made.