Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom jupyter-server templates #1697

Closed
GeorgianaElena opened this issue Sep 9, 2022 · 2 comments
Closed

Custom jupyter-server templates #1697

GeorgianaElena opened this issue Sep 9, 2022 · 2 comments
Assignees

Comments

@GeorgianaElena
Copy link
Member

GeorgianaElena commented Sep 9, 2022

Context

Currently we are able to provide custom templates for the hubs through https://github.com/2i2c-org/default-hub-homepage.

But a recent request to customize the look of the single user's server from #1439 (comment) generated this issue.

Do we want to provide customizations for jupyter-server templates? If so, where should we host this custom templates:?

Proposal

No response

Updates and actions

No response

@damianavila
Copy link
Contributor

@GeorgianaElena come up with a compromised solution in #1710.

But as I mentioned in the comments above, this implementation is a compromise. This was my own take on making this to work given the available time and feedback (at that time I considered this to be a time sensitive request, but turns out it wasn't).

In that PR I raised this comment:

Regardless of the specifics of the implementation, I have the feeling we are entering into the user image territory... It should relatively easy for them to self-serve the customization of the templates on the user image itself, right?

When I saw the problem I was immediately thinking about customization of the templates at the user image level.
Now re-reading the first message of this thread, I understand there might be a second option to allow community customization but still own the template repo as we do with the default-hub-homepage.

I am still not convinced about the second option because the tree and notebook, IMHO, belong to the user territory but happy to be convinced otherwise :wink.

@GeorgianaElena
Copy link
Member Author

It is possible to use singleuser.extraFiles config to customize certain jupyter templates. That is not suitable for complex UIs, but since we weren't requested to make complex changes, let's close this and reopen/open a new issue when/if this will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

No branches or pull requests

3 participants