Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically install dask-gateway CRDs for daskhubs #1486

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Jun 29, 2022

This PR adds a --dask-gateway-version CLI flag to the deploy action so that the appropriate CRDs for the dask-gateway helm chart can be installed automatically. It defaults to 2022.6.1, which is the current dask-gateway version we are running.

A deprecated CLI flag has also been removed.

fixes #1381

Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, consider it approved after that.

deployer/cli.py Show resolved Hide resolved
@sgibson91 sgibson91 merged commit 6de4d1e into 2i2c-org:master Jun 29, 2022
@sgibson91 sgibson91 deleted the install-dask-gateway-crds branch June 29, 2022 19:42
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deployment of cert-manager and dask-gateway require kubectl apply -f <crd manifests> step when version bumped
3 participants