-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment of cert-manager and dask-gateway require kubectl apply -f <crd manifests>
step when version bumped
#1381
Comments
@sgibson91 if you have 2022.4.0, the bump is fine without a CRD update, no change is made to the CRDs in this version update. |
I wasn't sure what the manifest URL for dask-gateway was and couldn't find an example in the docs, so I only updated cert-manager for now, but happy to do dask-gateway as well. |
@sgibson91 I made a note in the changelog for 2022.4.0 when an update was needed: https://gateway.dask.org/changelog.html#breaking-changes Note the part in the URL about 2022.4.0. You can opt to use
|
Feel free to ping me for review @sgibson91! |
Helm charts that include CRDs such as cert-manager and dask-gateway should typically by upgraded by doing
kubectl apply -f <crd manifests>
before being upgraded.The "default upgrade procedure" of cert-manager is to do this
kubectl apply
step manually first, and users of dask-gateway upgrading from 0.9.0 to 2022.4.0 were supposed to do that as well at least for that release, probably in general as well.For cert-manager, this can be done like in mybinder.org-deploy: https://github.com/jupyterhub/mybinder.org-deploy/blob/2db9dbdc8f51356713219dd2ddf72d0bb36723fb/deploy.py#L221-L253, and the same procedure can be used for dask-gateway.
Action point
kubectl apply
of CRDskubectl apply
of CRDsThe text was updated successfully, but these errors were encountered: