Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate installation of CRDs for cert-manager #1479

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Jun 28, 2022

  • Adds a CLI flag to deploy-support to set which version of cert-manager to install (this was previously hard-coded into the deployer)
  • Add a subprocess.check_call command to install cert-managers CRDs before installing/upgrading the chart

related #1381

Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be helpful when upgrading cert-manager beyond 1.3.1 to recent versions of 1.8 something I think.

The mybinder.org-deploy issue about cert-manager upgrade is here jupyterhub/mybinder.org-deploy#2183.

EDIT: opened #1480 about upgrading cert-manager.

@sgibson91 sgibson91 merged commit d9a22cc into 2i2c-org:master Jun 28, 2022
@sgibson91 sgibson91 deleted the install-crds branch June 28, 2022 14:49
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=branch%3Amaster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants