Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize sensors #144

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Reorganize sensors #144

merged 5 commits into from
Dec 5, 2024

Conversation

Serena1528
Copy link
Contributor

code for intake sensor and limelight was rearranged so that a) commands access sensor data from robot state instead of the intake subsystem and b) Limelight calculations happen within the Limelight subsystem, not the drivetrain subsystem

Copy link

@jbrelsf2-nmdp jbrelsf2-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the RobotState.getInstance; build is succeeding.

Copy link
Contributor

@jasonbrelsford jasonbrelsford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ready to merge. I submitted two reviews as my other account and did not work as expected.

@rflood07 rflood07 merged commit c1e85ff into main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants