Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tear down scaffolding for migrating to sessions w/ KMS contexts #2790

Merged
merged 5 commits into from
Mar 14, 2019
Merged

Tear down scaffolding for migrating to sessions w/ KMS contexts #2790

merged 5 commits into from
Mar 14, 2019

Conversation

jmhooper
Copy link
Member

Why: After #2787 is deployed, we won't be using contextless KMS for
session encryption anymore.

@jmhooper
Tear down scaffolding for migrating to sessions w/ KMS contexts
5694284 
**Why**: After #2787 is deployed, we won't be using contextless KMS for
session encryption anymore.

This should not be merged until after #2787 is deployed to production
and the feature flags have been adjusted to have the new instances write
sessions encrypted with KMS contexts.
paolov18F
paolov18F previously approved these changes Feb 27, 2019
View reviewed changes
stevegsa
stevegsa previously approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lauraGgit
lauraGgit approved these changes Mar 13, 2019
View reviewed changes
Copy link

@lauraGgit lauraGgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmhooper jmhooper merged commit e75875a into master Mar 14, 2019
@amathews-fs amathews-fs deleted the jmhooper-session-encryption-scaffolding branch January 7, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauraGgit lauraGgit lauraGgit approved these changes

@paolov18F paolov18F paolov18F left review comments

@stevegsa stevegsa stevegsa left review comments

@cpbgsa cpbgsa Awaiting requested review from cpbgsa

Assignees
No one assigned
Labels
status - do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmhooper @lauraGgit @stevegsa @paolov18F