Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encryption contexts to session KMS events #2787

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Add encryption contexts to session KMS events #2787

merged 2 commits into from
Feb 26, 2019

Conversation

jmhooper
Copy link
Member

Why: So they will show up in cloudtrail with a context, which
separates them from legacy password encryption events

@jmhooper
Add encryption contexts to session KMS events
7e73f23 
**Why**: So they will show up in cloudtrail with a context, which
separates them from legacy password encryption events
@jmhooper jmhooper merged commit 5f1a887 into master Feb 26, 2019
jmhooper added a commit that referenced this pull request Feb 27, 2019
@jmhooper
Tear down scaffolding for migrating to sessions w/ KMS contexts
5694284 
**Why**: After #2787 is deployed, we won't be using contextless KMS for
session encryption anymore.

This should not be merged until after #2787 is deployed to production
and the feature flags have been adjusted to have the new instances write
sessions encrypted with KMS contexts.
@jmhooper jmhooper mentioned this pull request Feb 27, 2019
Merged
cpbgsa pushed a commit that referenced this pull request Mar 5, 2019
@jmhooper @clarabridges
Add encryption contexts to session KMS events (#2787)
9ac663b 
**Why**: So they will show up in cloudtrail with a context, which
separates them from legacy password encryption events
@brodygov brodygov deleted the jmhooper-session-encryption-context branch March 7, 2019 20:26
@brodygov brodygov mentioned this pull request Mar 7, 2019
Merged
jmhooper added a commit that referenced this pull request Mar 14, 2019
@jmhooper
Tear down scaffolding for migrating to sessions w/ KMS contexts (#2790)
e75875a 
**Why**: After #2787 is deployed, we won't be using contextless KMS for
session encryption anymore.

This should not be merged until after #2787 is deployed to production
and the feature flags have been adjusted to have the new instances write
sessions encrypted with KMS contexts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolov18F paolov18F paolov18F approved these changes

@cpbgsa cpbgsa cpbgsa approved these changes

@jgrevich jgrevich Awaiting requested review from jgrevich

@stevegsa stevegsa Awaiting requested review from stevegsa

Assignees
No one assigned
Labels
status - ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhooper @cpbgsa @paolov18F