Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convention on asset retention #11381

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

lmgeorge
Copy link
Contributor

Why
While authoring a different feature, it became apparent that we do not store multiple variants of asset "just in case". We can re-export from our authoring tools (i.e., Figma) if need be.

This adds a note why we do not do this for developers from the future.

[skip changelog]

**Why**
While authoring a different feature, it became apparent that we do not store multiple variants of asset "just in case". We can re-export from our authoring tools (i.e., Figma) if need be.

This adds a note why we do not do this for developers from the future.

[skip changelog]
@lmgeorge lmgeorge requested a review from aduth October 22, 2024 18:42
@lmgeorge
Copy link
Contributor Author

@aduth - here's that tiny PR I said I'd make on our how we author and version control assets.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmgeorge lmgeorge merged commit 9c51be0 into main Oct 22, 2024
2 checks passed
@lmgeorge lmgeorge deleted the lmgeorge/docs-conventions-on-asset-retention branch October 22, 2024 21:02
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
**Why**
While authoring a different feature, it became apparent that we do not store multiple variants of asset "just in case". We can re-export from our authoring tools (i.e., Figma) if need be.

This adds a note why we do not do this for developers from the future.

[skip changelog]
MrNagoo pushed a commit that referenced this pull request Oct 25, 2024
**Why**
While authoring a different feature, it became apparent that we do not store multiple variants of asset "just in case". We can re-export from our authoring tools (i.e., Figma) if need be.

This adds a note why we do not do this for developers from the future.

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants