-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-14642: Update design and copy of GPO 'letter on the way' email #11351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Oct 16, 2024
lmgeorge
commented
Oct 16, 2024
lmgeorge
commented
Oct 16, 2024
c3c813e
to
3a1d126
Compare
lmgeorge
commented
Oct 16, 2024
lmgeorge
commented
Oct 16, 2024
Author's note: currently waiting for program requirements to be met before this can be merged This work has been accepted, but still needs final business approval from program. |
aduth
reviewed
Oct 17, 2024
bb9daeb
to
e037835
Compare
lmgeorge
commented
Oct 22, 2024
lmgeorge
commented
Oct 22, 2024
jmhooper
approved these changes
Oct 22, 2024
1fd39b7
to
23b0cc2
Compare
**Why** - Align the 'letter requested' design and language with our current design requirements **How** - Rewrote the email template to utilize the new language and iconography. - The template handles more complexity -- if the ServiceProvider is absent or has incomplete configuration details, we account for that and either hide or modify certain instructions and the call-to-action. This business logic is stored in a new presenter (`Idv::ByMail::LetterRequestedPresenter`). - Replaced `user_mailer.letter_reminder.*` with new message properties under `user_mailer.verify_by_mail_letter_requested.*` - Updated the Rails mailer previewer to include a dummy ServiceProvider and User with a pending profile to reflect the new content. changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification
23b0cc2
to
85ca1f9
Compare
MrNagoo
pushed a commit
that referenced
this pull request
Oct 29, 2024
…1351) LG-14642: Update design and copy of GPO 'letter on the way' email **Why** - Align the 'letter requested' design and language with our current design requirements **How** - Rewrote the email template to utilize the new language and iconography. - The template handles more complexity -- if the ServiceProvider is absent or has incomplete configuration details, we account for that and either hide or modify certain instructions and the call-to-action. This business logic is stored in a new presenter (`Idv::ByMail::LetterRequestedPresenter`). - Replaced `user_mailer.letter_reminder.*` with new message properties under `user_mailer.verify_by_mail_letter_requested.*` - Updated the Rails mailer previewer to include a dummy ServiceProvider and User with a pending profile to reflect the new content. changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification --------- Co-authored-by: Jonathan Hooper <[email protected]>
KeithNava
pushed a commit
that referenced
this pull request
Oct 31, 2024
…1351) LG-14642: Update design and copy of GPO 'letter on the way' email **Why** - Align the 'letter requested' design and language with our current design requirements **How** - Rewrote the email template to utilize the new language and iconography. - The template handles more complexity -- if the ServiceProvider is absent or has incomplete configuration details, we account for that and either hide or modify certain instructions and the call-to-action. This business logic is stored in a new presenter (`Idv::ByMail::LetterRequestedPresenter`). - Replaced `user_mailer.letter_reminder.*` with new message properties under `user_mailer.verify_by_mail_letter_requested.*` - Updated the Rails mailer previewer to include a dummy ServiceProvider and User with a pending profile to reflect the new content. changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification --------- Co-authored-by: Jonathan Hooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area - usability
status - accepted
Work that has passed acceptance, but may not be greenlit for release
type - enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Idv::ByMail::LetterRequestedPresenter
).user_mailer.letter_reminder.*
with new message properties underuser_mailer.verify_by_mail_letter_requested.*
Additional Notes
As we utilize
Rails.application.routes.url_helpers
directly in the presenter,LocaleHelper#with_user_locale
also needed to handle updating the locale within theurl_options
hash while also maintaining support for services that do not useurl_helpers
directly (e.g.,SendProofingNotificationJob
).By default, it appears that Rspec mocks
url_options
with a frozen hash, so we simply override it for the purposes of testing. A scenario whereurl_options
is defined but equal tonil
is not supported. In the event this happens, we want the interpreter to throw an error because it likely indicates a serious misconfiguration or bug in the app.changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification
🎫 Ticket
Link to the relevant ticket:
LG-14642