Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14642: Update design and copy of GPO 'letter on the way' email #11351

Merged
merged 10 commits into from
Oct 28, 2024

Conversation

lmgeorge
Copy link
Contributor

@lmgeorge lmgeorge commented Oct 16, 2024

Why

  • Align the 'letter requested' design and language with our current design requirements

How

  • Rewrote the email template to utilize the new language and iconography.
  • The template handles more complexity -- if the ServiceProvider is absent or has incomplete configuration details, we account for that and either hide or modify certain instructions and the call-to-action. This business logic is stored in a new presenter (Idv::ByMail::LetterRequestedPresenter).
  • Replaced user_mailer.letter_reminder.* with new message properties under user_mailer.verify_by_mail_letter_requested.*
  • Updated the Rails mailer previewer to include a dummy ServiceProvider and User with a pending profile to reflect the new content.

Additional Notes
As we utilize Rails.application.routes.url_helpers directly in the presenter, LocaleHelper#with_user_locale also needed to handle updating the locale within the url_options hash while also maintaining support for services that do not use url_helpers directly (e.g., SendProofingNotificationJob).

By default, it appears that Rspec mocks url_options with a frozen hash, so we simply override it for the purposes of testing. A scenario where url_options is defined but equal to nil is not supported. In the event this happens, we want the interpreter to throw an error because it likely indicates a serious misconfiguration or bug in the app.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification

🎫 Ticket

Link to the relevant ticket:
LG-14642

@lmgeorge lmgeorge requested review from aduth and jmhooper October 16, 2024 21:08
@lmgeorge
Copy link
Contributor Author

lmgeorge commented Oct 16, 2024

Author's note: currently waiting for program requirements to be met before this can be merged , but review and acceptance can still happen!

This work has been accepted, but still needs final business approval from program.

@lmgeorge lmgeorge added status - accepted Work that has passed acceptance, but may not be greenlit for release and removed status - ready for review status - blocked labels Oct 22, 2024
**Why**

- Align the 'letter requested' design and language with our current
  design requirements

**How**

- Rewrote the email template to utilize the new language and iconography.
- The template handles more complexity -- if the ServiceProvider is absent or has incomplete
  configuration details, we account for that and either hide or modify certain
  instructions and the call-to-action. This business logic is stored in
  a new presenter (`Idv::ByMail::LetterRequestedPresenter`).
- Replaced `user_mailer.letter_reminder.*` with new message properties under
  `user_mailer.verify_by_mail_letter_requested.*`
- Updated the Rails mailer previewer to include a dummy ServiceProvider
  and User with a pending profile to reflect the new content.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification
@lmgeorge lmgeorge merged commit 085a3f1 into main Oct 28, 2024
2 checks passed
@lmgeorge lmgeorge deleted the lmgeorge/LG-14642 branch October 28, 2024 14:12
MrNagoo pushed a commit that referenced this pull request Oct 29, 2024
…1351)

LG-14642: Update design and copy of GPO 'letter on the way' email

**Why**

- Align the 'letter requested' design and language with our current
  design requirements

**How**

- Rewrote the email template to utilize the new language and iconography.
- The template handles more complexity -- if the ServiceProvider is absent or has incomplete
  configuration details, we account for that and either hide or modify certain
  instructions and the call-to-action. This business logic is stored in
  a new presenter (`Idv::ByMail::LetterRequestedPresenter`).
- Replaced `user_mailer.letter_reminder.*` with new message properties under
  `user_mailer.verify_by_mail_letter_requested.*`
- Updated the Rails mailer previewer to include a dummy ServiceProvider
  and User with a pending profile to reflect the new content.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification

---------

Co-authored-by: Jonathan Hooper <[email protected]>
KeithNava pushed a commit that referenced this pull request Oct 31, 2024
…1351)

LG-14642: Update design and copy of GPO 'letter on the way' email

**Why**

- Align the 'letter requested' design and language with our current
  design requirements

**How**

- Rewrote the email template to utilize the new language and iconography.
- The template handles more complexity -- if the ServiceProvider is absent or has incomplete
  configuration details, we account for that and either hide or modify certain
  instructions and the call-to-action. This business logic is stored in
  a new presenter (`Idv::ByMail::LetterRequestedPresenter`).
- Replaced `user_mailer.letter_reminder.*` with new message properties under
  `user_mailer.verify_by_mail_letter_requested.*`
- Updated the Rails mailer previewer to include a dummy ServiceProvider
  and User with a pending profile to reflect the new content.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification

---------

Co-authored-by: Jonathan Hooper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - usability status - accepted Work that has passed acceptance, but may not be greenlit for release type - enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants