Remove compose-components JavaScript package #11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Maintenance, Remove compose-components JavaScript package
mitchellhenke
force-pushed
the
mitchellhenke/remove-compose-components
branch
from
2b5be41 to
76cad2b
Compare
mitchellhenke
requested review from
a team,
jmax-gsa,
WilliamBirdsall and
amirbey
and removed request for
a team and
jmax-gsa
colter-nattrass
pushed a commit
that referenced
this pull request
Oct 23, 2024
* placeholder 2 * remove compose-components changelog: Internal, Maintenance, Remove compose-components JavaScript package
MrNagoo
pushed a commit
that referenced
this pull request
Oct 25, 2024
* placeholder 2 * remove compose-components changelog: Internal, Maintenance, Remove compose-components JavaScript package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Addresses an issue identified as part of #11333 where TypeScript did not catch some issues due to how we were creating components in
compose-components. The package was added in #5535 to avoid the verbosity and deep indenting that would otherwise be required.This PR effectively undoes that and removes the package to improve the ability for TypeScript to detect type errors around components.