Extend session when changing document capture steps #11333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Bug Fixes, Document Capture, Extend session when moving between document capture steps
mitchellhenke
force-pushed
the
mitchellhenke/fix-extend-session-in-document-capture
branch
from
e85720f to
8072022
Compare
aduth
approved these changes
Oct 10, 2024
spec/javascript/packages/document-capture/components/document-capture-spec.jsx
Outdated
Show resolved
Hide resolved
…capture-spec.jsx Co-authored-by: Andrew Duthie <[email protected]>
mitchellhenke
force-pushed
the
mitchellhenke/fix-extend-session-in-document-capture
branch
from
e93e61f to
799f0f1
Compare
mitchellhenke
deleted the
mitchellhenke/fix-extend-session-in-document-capture
branch
Merged
colter-nattrass
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Extend session when moving between document capture steps changelog: Bug Fixes, Document Capture, Extend session when moving between document capture steps * Update spec/javascript/packages/document-capture/components/document-capture-spec.jsx Co-authored-by: Andrew Duthie <[email protected]> --------- Co-authored-by: Andrew Duthie <[email protected]>
MrNagoo
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Extend session when moving between document capture steps changelog: Bug Fixes, Document Capture, Extend session when moving between document capture steps * Update spec/javascript/packages/document-capture/components/document-capture-spec.jsx Co-authored-by: Andrew Duthie <[email protected]> --------- Co-authored-by: Andrew Duthie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14545
🛠 Summary of changes
This fixes a regression from #10894 which added an argument to
extendSession, but did not add it for the usage in document capture. #11287 was a short-term fix, and this more fully addresses it by defining sessionsURL as we do for other URLs.The regression is something that TypeScript could catch, but requires bigger changes.