Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14290- Add step indicator to How To Verify View - Fix Specs #11314

Merged

Conversation

gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Oct 4, 2024

🎫 Ticket

LG-14290 Eng: Add step indicator component to Opt-in page (How to Verify)

🛠 Summary of changes

  • Update specs per review here
    1. Removed parentheses used inside it description in spec file
    2. Update specs to make readable

📜 Testing Plan

  • Run specs in spec/views/idv/how_to_verify/show.html.erb_spec.rb and check for readability (you can also look in screenshots)

👀 Screenshots

Before: Screenshot 2024-10-04 at 12 31 01 PM
After: Screenshot 2024-10-04 at 12 29 26 PM

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I hadn't seen that we had a "context" that was trying to do the human-readable sentence that I mentioned in my review comment, but I think your revisions here are much better for what I'd expect, since I wouldn't expect context to be used in that way 👍

@gina-yamada gina-yamada merged commit a2dc450 into main Oct 4, 2024
2 checks passed
@gina-yamada gina-yamada deleted the yamada/LG-14290-Add-Step-Indicator-Part-2-Fix-Spec branch October 4, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants