Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14290- Add step indicator to How To Verify View #11298

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Sep 30, 2024

🎫 Ticket

LG-14290 Eng: Add step indicator component to Opt-in page (How to Verify)

🛠 Summary of changes

  • Add Step Indicator Component to How to Verify View
  • Set current step as "Getting started"

📜 Testing Plan

  • Step 1 Ensure the following variables are set to true in config.application.yml; in_person_proofing_opt_in_enabled and in_person_proofing_enabled
  • Step 2 Start identity-idp and identity-oidc-sinatra severs. Enter Login via localhost:9292. Create an account. Step through the app to begin identity verification. Visit /verify/welcome and then /verify/agreement. Open the console. Continue on. Next you will land on /verify/how_to_verify.
  • Step 3 Confirm you can see the step indicator on the page. Confirm you see the following 5 steps: Getting started, Verify your ID, Verify your information, Verify your phone number, Re-enter your password.
  • Step 4 Confirm current step is Getting started
  • Step 5 Confirm there are no errors in the console
  • Step 6 Check that the step nav is responsive
  • Step 7 Change the language to ensure the step nav is being translated for each language (Spanish, French, Chinese)
  • Step 8 Visit /verify/how_to_verify from a different path (not coming from /verify/agreement)- ie: Click the 'Cancel' link at the bottom and then click on button 'No, keep going'. Confirm step 3 - step 6 is working as expected.
  • Step 9 Visit /verify/how_to_verify from a different path (not coming from /verify/agreement) - ie: Click the 'Continue in person' button. Once on verify/document_capture (Verify your identity in person), confirm the step nav changed. (Find a Post Office, Verify your information, Verify your phone number, Re-enter your password, Go to the Post Office). Then click the 'Back' link on this page. You should be on /verify/how_to_verify again. Confirm step 3 - step 6 is working as expected.
  • Step 10 Play around with getting to /verify/how_to_verify in other paths not mentioned for step 2, 8 or 9. I don't think there are other paths but double check. Goal is to confirm there are no errors and the correct step is selected from any entry point
  • Step 11 Go to file app/controllers/idv/how_to_verify_controller.rb and set @selfie_required to true in method set_how_to_verify_presenter. Confirm Step nav displays on the page and that current step is Getting started
  • Step 12 Go to file app/controllers/idv/how_to_verify_controller.rb and set @selfie_required to false in method set_how_to_verify_presenter. Confirm Step nav displays on the page and that current step is Getting started

👀 Screenshots

Before: Screenshot 2024-09-30 at 1 39 12 PM
After:

Screenshot 2024-09-30 at 1 13 11 PM

After (Responsive):

Screenshot 2024-09-30 at 1 12 59 PM

Screenshot 2024-09-30 at 1 12 47 PM

Screenshot 2024-09-30 at 1 12 35 PM

Screenshot 2024-09-30 at 1 12 19 PM

After (Languages): Screenshot 2024-09-30 at 1 41 04 PM Screenshot 2024-09-30 at 1 41 14 PM Screenshot 2024-09-30 at 1 41 23 PM
After (Biometrics):

Screenshot 2024-09-30 at 2 18 30 PM

Screenshot 2024-09-30 at 2 19 09 PM

@gina-yamada gina-yamada requested review from a team, rutvigupta-design, jennyverdeyen and kellular and removed request for a team and rutvigupta-design September 30, 2024 17:48
@gina-yamada
Copy link
Contributor Author

Thanks @KeithNava for the review!

Copy link
Member

@jennyverdeyen jennyverdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing steps all pass, code looks good to me!

@gina-yamada
Copy link
Contributor Author

@sumiat There are screenshots above in the description. Thank you

@gina-yamada gina-yamada requested review from sumiat and removed request for kellular October 1, 2024 17:19
@sumiat
Copy link

sumiat commented Oct 2, 2024

thanks @gina-yamada, looks good!

@gina-yamada gina-yamada merged commit 9a81e19 into main Oct 3, 2024
2 checks passed
@gina-yamada gina-yamada deleted the yamada/LG-14290-Add-Step-Indicator branch October 3, 2024 13:38
MrNagoo pushed a commit that referenced this pull request Oct 3, 2024
* Add step indicator to how to verify view

* changelog: User-Facing Improvements, In-person proofing, Add step indicator to how to verify view
@@ -18,6 +18,13 @@
end

context 'renders the show template with' do
it('a step indicator with Getting started as the current step') do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventionally, we don't include parentheses for RSpec BDD methods.

I would also personally expect the "it" parameterization to read as a human-readable sentence. Currently it lacks a verb of what "it" is doing.

Suggested change
it('a step indicator with Getting started as the current step') do
it 'renders a step indicator with Getting started as the current step' do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduth Ahh, good eye! Thank you
Updates made here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates merged in. Thanks for the review

colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* Add step indicator to how to verify view

* changelog: User-Facing Improvements, In-person proofing, Add step indicator to how to verify view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants