-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-14290- Add step indicator to How To Verify View #11298
Conversation
…icator to how to verify view
Thanks @KeithNava for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing steps all pass, code looks good to me!
@sumiat There are screenshots above in the description. Thank you |
…90-Add-Step-Indicator
thanks @gina-yamada, looks good! |
…90-Add-Step-Indicator
* Add step indicator to how to verify view * changelog: User-Facing Improvements, In-person proofing, Add step indicator to how to verify view
@@ -18,6 +18,13 @@ | |||
end | |||
|
|||
context 'renders the show template with' do | |||
it('a step indicator with Getting started as the current step') do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conventionally, we don't include parentheses for RSpec BDD methods.
I would also personally expect the "it" parameterization to read as a human-readable sentence. Currently it lacks a verb of what "it" is doing.
it('a step indicator with Getting started as the current step') do | |
it 'renders a step indicator with Getting started as the current step' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates merged in. Thanks for the review
* Add step indicator to how to verify view * changelog: User-Facing Improvements, In-person proofing, Add step indicator to how to verify view
🎫 Ticket
LG-14290 Eng: Add step indicator component to Opt-in page (How to Verify)
🛠 Summary of changes
📜 Testing Plan
in_person_proofing_opt_in_enabled
andin_person_proofing_enabled
identity-idp
andidentity-oidc-sinatra
severs. Enter Login vialocalhost:9292
. Create an account. Step through the app to begin identity verification. Visit/verify/welcome
and then/verify/agreement
. Open the console. Continue on. Next you will land on/verify/how_to_verify
.Getting started
/verify/how_to_verify
from a different path (not coming from/verify/agreement
)- ie: Click the 'Cancel' link at the bottom and then click on button 'No, keep going'. Confirm step 3 - step 6 is working as expected./verify/how_to_verify
from a different path (not coming from/verify/agreement
) - ie: Click the 'Continue in person' button. Once onverify/document_capture
(Verify your identity in person), confirm the step nav changed. (Find a Post Office, Verify your information, Verify your phone number, Re-enter your password, Go to the Post Office). Then click the 'Back' link on this page. You should be on/verify/how_to_verify
again. Confirm step 3 - step 6 is working as expected./verify/how_to_verify
in other paths not mentioned for step 2, 8 or 9. I don't think there are other paths but double check. Goal is to confirm there are no errors and the correct step is selected from any entry pointapp/controllers/idv/how_to_verify_controller.rb
and set@selfie_required
to true in methodset_how_to_verify_presenter
. Confirm Step nav displays on the page and that current step isGetting started
app/controllers/idv/how_to_verify_controller.rb
and set@selfie_required
to false in methodset_how_to_verify_presenter
. Confirm Step nav displays on the page and that current step isGetting started
👀 Screenshots
Before:
After:
After (Responsive):
After (Languages):
After (Biometrics):