Fix build setup to be compatible with latest Federalist release #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Required for interoperability with Federalist pending upcoming platform changes.
**Why**: Previously needed because Federalist would only install dependencies, and we rely on devDependencies for the site build. This is changing in an upcoming Federalist release where all dependencies will be installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Federalist will install all dependencies for us. Previously we needed to re-run the NPM install in order to install development dependencies in addition to production dependencies. As of the Federalist release this past Friday, it will install all dependencies, so this will no longer be necessary.
Note: All Federalist builds will fail until this pull request is merged.
Related discussion: https://gsa-tts.slack.com/archives/C1NUUGTT5/p1617287819021500