Skip to content

Commit

Permalink
Fix build setup to be compatible with latest Federalist release (#211)
Browse files Browse the repository at this point in the history
* Remove bundler install tasks from NPM prepare script

**Why**: Required for interoperability with Federalist pending upcoming platform changes.

* Remove npm install from Federalist script

**Why**: Previously needed because Federalist would only install dependencies, and we rely on devDependencies for the site build. This is changing in an upcoming Federalist release where all dependencies will be installed.
  • Loading branch information
aduth authored Apr 6, 2021
1 parent 1a63c2c commit ba2b1f7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
6 changes: 0 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ ifdef SITE_PREFIX
OUTPUT_DIR = ./_site
endif

install-jekyll: install-bundler
bundle check || bundle install

install-bundler:
gem list -i bundler || gem install bundler

start: start-docs start-assets

start-docs:
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ The following dependencies are required to build the documentation and assets wi
- [Ruby](.ruby-version)
- [Node.js](.nvmrc)

After satisfying the above language dependencies and cloning this repository, install package dependencies with `npm`:
After satisfying the above language dependencies and cloning this repository, install package dependencies:

```
npm install
bundle install
```

In development, build the documentation site with assets, watch source files for changes, and serve the compiled site at [localhost:4000](http://localhost:4000) by running:
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
"test-pa11y": "make test-runner-pa11y",
"test-jest": "make test-runner-jest",
"build": "make build",
"federalist": "npm install && make build-assets",
"prepare": "make install-jekyll",
"federalist": "make build-assets",
"prepublishOnly": "make lint && make clean && make build-assets build-package"
},
"files": [
Expand Down

0 comments on commit ba2b1f7

Please sign in to comment.