Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return type of function decodeEvents #205

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Change return type of function decodeEvents #205

merged 2 commits into from
Nov 29, 2022

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Aug 30, 2022 •
edited
Loading

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Created a PR to the plugin branch of starknet-hardhat-example:
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.sh)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL requested a review from FabijanC August 30, 2022 07:01
FabijanC
FabijanC reviewed Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also require changes in the example repo?

@FabijanC FabijanC self-requested a review November 29, 2022 09:51
@FabijanC FabijanC merged commit 4b0814f into release-0.7.0 Nov 29, 2022
@FabijanC FabijanC deleted the decode-events-type branch November 29, 2022 09:52
FabijanC added a commit that referenced this pull request Dec 2, 2022
@FabijanC @Nathan-SL
Introduce some breaking changes for 0.7.0 (#199) [skip ci]
ee977a8 
* Make account-contract a flag in starknet-verify (#198)

* Calculate estimateFee Implicitly (#206)

* Change return type of function decodeEvents (#205)

Co-authored-by: Nathan <[email protected]>
Co-authored-by: Nathan-SL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nathan-SL @FabijanC