feat: use the GenericError for all the errors originating from the agglayer (cherry-pick)
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
changed the title
Stefan-Ethernal
changed the title
GenericError for all the errors originating from the agglayer (cherry-pick)
…agglayer (#227) * chore: update the versions.json * Remove PPError interface and use the error instead * Remove non-applicable test cases * Rename * test: increase UT coverage * test: certificate status unmarshal json * test: TestMerkleProofString * test: TestGlobalIndexString * test: move helper functions to a separate file * test: TestL1InfoTreeLeafString * test: TestClaimType * test: parallel execution, renames
Stefan-Ethernal
force-pushed
the
chore/cherry-pick-pr-227
branch
from
27139e6 to
37d79f9
Compare
|
Stefan-Ethernal
requested review from
goran-ethernal,
joanestebanr and
ToniRamirezM
goran-ethernal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick #227 to the
developbranch.Use the
GenericErrorfor all the errors originating from the agglayer. Even in case some error occurs when unmarshalling, suppress propagation and embed it into theGenericErrorinstance.Note: wait for #229 to get merged, in order to pass the unit tests.