fix: use hex instead of byte arrays in Certificate marshalling #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
fix/cdk-620-use-hex-in-certificates
branch
from
ffe75a0 to
687dc2d
Compare
goran-ethernal
force-pushed
the
fix/cdk-620-use-hex-in-certificates
branch
from
45a1bb7 to
3f72166
Compare
Stefan-Ethernal
approved these changes
Dec 9, 2024
Stefan-Ethernal
approved these changes
Dec 9, 2024
|
joanestebanr
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the use of hex strings for hashes in the certficate that is sent to the agglayer rpc, instead of byte arrays, to reduce the certificate size that is transferred through the rpc call.