fix: last sent certificate block underflow #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
changed the base branch from
release/v0.5.0
to
feat/cherry-pick-pr-229-to-release
goran-ethernal
force-pushed
the
feat/cherry-pick-pr-229-to-release
branch
from
ce5217c to
9eec22f
Compare
goran-ethernal
force-pushed
the
fix/last-sent-certificate-block-underflow
branch
from
294f831 to
0f1c76e
Compare
Stefan-Ethernal
approved these changes
Dec 6, 2024
|
rachit77
approved these changes
Dec 6, 2024
goran-ethernal
merged commit 678fc17
into
feat/cherry-pick-pr-229-to-release
11 of 12 checks passed
goran-ethernal
added a commit
that referenced
this pull request
Dec 6, 2024
* fix: use hex instead of byte arrays * feat: UT * fix: change estimated certificate size * fix: UT coverage * fix: bridge exit metadata hash * fix: last sent certificate block (#234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue occurred while testing, where an uint64 underflow happens when we calculate the previousToBlock on
aggsender.