Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4673 fix(portal): drop graphql related prs on main #895

Conversation

Vitalsine85
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

Reverts ENG-4659, 4656, and 4662 in favor of moving all GraphQL related work in Portal to a feature branch. This will allow us to maintain and push releases of Portal without being tied down by the migration.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Nov 7, 2024

@jonathanprozzi
Copy link
Member

This looks good to me but still marking with do not merge until we all have a chance to sync

Copy link
Member

@jonathanprozzi jonathanprozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comment -- added do not merge until we align, but this looks good. Thanks for doing this @Vitalsine85

We should hopefully be able to open PRs again onto the feature branch but we should sync about that as a squad.

@jonathanprozzi
Copy link
Member

Marking this ready to merge so that we can cut a release

@jonathanprozzi jonathanprozzi changed the title ENG-4673 fix(portal): Revert GQL related PRs on main ENG-4673 fix(portal): drop graphql related prs on main Nov 8, 2024
@jonathanprozzi jonathanprozzi merged commit 025d142 into main Nov 8, 2024
4 checks passed
@jonathanprozzi jonathanprozzi deleted the vital/eng-4670-switch-to-a-feature-branch-approach-for-the-graphql-work-so branch November 8, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants