-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-4662 feat(portal,1ui,graphql): update query in create identity modal #889
ENG-4662 feat(portal,1ui,graphql): update query in create identity modal #889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lmk about specifics with codegen issue since I want to try to avoid adding this as a dep if possible! Otherwise looks good!
@@ -33,6 +33,7 @@ | |||
}, | |||
"devDependencies": { | |||
"@0no-co/graphqlsp": "^1.12.16", | |||
"dotenv-cli": "^7.4.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this dependency? Curious if it was needed for something you ran into
Edit: saw codegen comment. What error? Did you run from the root? Also did you run to add any new queries? Trying to see if this is an issue we can solve without adding this as a dependency- I haven't had issues with codegen but if you saw errors lmk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➜ intuition-ts git:(vital/eng-4662-update-queries-in-create-identity-modal) ✗ pnpm run graphql:codegen
> @0xintuition/intuition-ts@ graphql:codegen /home/vital/Git/intuition/intuition-ts
> nx codegen @0xintuition/graphql
> nx run @0xintuition/graphql:codegen
> @0xintuition/[email protected] codegen /home/vital/Git/intuition/intuition-ts/packages/graphql
> dotenv graphql-codegen --config codegen.ts
sh: 1: dotenv: not found
ELIFECYCLE Command failed.
———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————
NX Ran target codegen for project @0xintuition/graphql (514ms)
✖ 1/1 failed
✔ 0/1 succeeded [0 read from cache]
ELIFECYCLE Command failed with exit code 1.
This is what I was seeing, added dotenv-cli to devDependencies based on Claudes comments. I think I could have installed it locally and it would have worked. Can remove it though if we need to. I'm assuming you must have it installed on your local machine?
minDeposit: string | ||
} | ||
|
||
export function useCreateConfig() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Good idea!
Affected Packages
Apps
Packages
Tools
Overview
Screen Captures
If applicable, add screenshots or screen captures of your changes.
Declaration