Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3716 fix(portal): fix navigation on error page #809

Conversation

Vitalsine85
Copy link
Member

@Vitalsine85 Vitalsine85 commented Aug 28, 2024

Affected Packages

Apps

  • portal

Packages

  • 1ui
  • api
  • protocol
  • sdk

Tools

  • tools

Overview

The navigation buttons on the error page weren't properly refreshing or navigating when used. Modified them slightly so that they should work appropriately.

Screen Captures

If applicable, add screenshots or screen captures of your changes.

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

PR Summary by Typo

Summary:
Replaced a NavigationButton with a Button for non-root error pages and updated the props for the home button.

Key Points:

  • Replaced NavigationButton with a Button for non-root error pages.
  • Updated home button props to use PATHS.ROOT and a click event for window.location.reload() instead of to="" and reloadDocument prop.

Categories:
Components: error-page.tsx

  • Replaced NavigationButton with Button.
  • Updated home button props.

Changes:

  • Used a Button instead of NavigationButton.
  • Changed home button props to PATHS.ROOT and window.location.reload() event.
To turn off PR summary, please visit Notification settings.

Copy link

linear bot commented Aug 28, 2024

ENG-3716 [REFRESH / ERROR PAGE] 'Refresh' & 'Back to Home' buttons don't fix anything, but manually refreshing the page / entering a new URL fixes the issue

Description:

Browser's refresh button works / hard refresh works, but the buttons on the page that say 'Refresh' or 'Back to Home' don't work.


// Test Lead Notes //

@github-actions github-actions bot added the fix Fix label Aug 28, 2024
@Vitalsine85 Vitalsine85 enabled auto-merge (squash) August 30, 2024 15:21
@Vitalsine85 Vitalsine85 merged commit f7d2321 into main Aug 30, 2024
3 checks passed
@Vitalsine85 Vitalsine85 deleted the vital/eng-3716-refresh-error-page-refresh-back-to-home-buttons-dont-fix branch August 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants