Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support IDNA in lists #963

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ThinkChaos
Copy link
Collaborator

Not sure this is actually supported by most adblocker, but we might as well be permissive.

Fixes #961.

Not sure this is actually supported by most adblocker, but we might as
well be permissive.
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 82.35% and project coverage change: -0.04 ⚠️

Comparison is base (30ead04) 93.64% compared to head (9a9681d) 93.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   93.64%   93.60%   -0.04%     
==========================================
  Files          63       63              
  Lines        5304     5320      +16     
==========================================
+ Hits         4967     4980      +13     
- Misses        264      266       +2     
- Partials       73       74       +1     
Impacted Files Coverage Δ
lists/parsers/hosts.go 97.72% <82.35%> (-2.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThinkChaos
Copy link
Collaborator Author

The only line not covered is just a return "", err.
Not sure how to trigger an error with idna.Punycode, so I'd just ignore that hole here.

@0xERR0R 0xERR0R added this to the v0.22 milestone Mar 29, 2023
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Mar 29, 2023
Copy link
Owner

@0xERR0R 0xERR0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ThinkChaos ThinkChaos merged commit f887e82 into 0xERR0R:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support international domain names in lists (IDNA)
3 participants