Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support international domain names in lists (IDNA) #961

Closed
ThinkChaos opened this issue Mar 28, 2023 Discussed in #960 · 1 comment · Fixed by #963
Closed

Support international domain names in lists (IDNA) #961

ThinkChaos opened this issue Mar 28, 2023 Discussed in #960 · 1 comment · Fixed by #963
Labels
🔨 enhancement New feature or request
Milestone

Comments

@ThinkChaos
Copy link
Collaborator

See #960

Example list: https://raw.githubusercontent.com/rahilpathan/pihole-whitelist/main/1.LowWL.txt
Fix idea: use the idna module's ToASCII to convert those domains to their punycode representation which is what blocky should receive from clients.

@ThinkChaos ThinkChaos added the 🐞 bug Something isn't working label Mar 28, 2023
@ThinkChaos ThinkChaos changed the title Supoprt international domain names in lists (IDNA) Support international domain names in lists (IDNA) Mar 28, 2023
@0xERR0R 0xERR0R added 🔨 enhancement New feature or request and removed 🐞 bug Something isn't working labels Mar 29, 2023
@0xERR0R
Copy link
Owner

0xERR0R commented Mar 29, 2023

I changed it from bug to feature 😄

We support currently lists in hosts file format or plain domain names. A particular domain name may contain only letters, numbers (and some special characters like hyphen). List maintainers should validate its content and use only valid names.

It is a very good idea to convert list content on-the-fly to punycode if necessary. Since user can also create his own lists or use inline definitions. 👍

@0xERR0R 0xERR0R added this to the v0.22 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants