Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make blobber ID mandatory in sdk.GetStakePoolInfo #602

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Oct 14, 2022

Changes

blobber_id field is actually mandatory for sp-info. But if I dont provide any blobber, it takes client ID as default blobber_id. This is incorrect. Since blobber_id is necessary, we should take it from command line arguments.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@boddumanohar boddumanohar requested a review from cnlangzi October 14, 2022 07:06
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit e9d2dda into staging Oct 17, 2022
@cnlangzi cnlangzi deleted the blobber_id-mandatory branch October 17, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants