make blobberID field mandatory for sp-info command #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boddumanohar
force-pushed
the
blobber_id-mandatory
branch
from
de96f2d to
f8f9869
Compare
cnlangzi
suggested changes
Oct 13, 2022
Co-authored-by: Lz <[email protected]>
Co-authored-by: Lz <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the changes in this PR:
blobber_id field is actually mandatory for sp-info. But if I dont provide any blobber, it takes client ID as default blobber_id. This is incorrect. Since blobber_id is necessary, we should take it from command line arguments.
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):