Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infocomplete: Complete filetypes #3090

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

JoeKar
Copy link
Collaborator

@JoeKar JoeKar commented Dec 12, 2023

This will add the capability to auto complete the filetype option.

Attention:
The duplicated entries will be solved with #3066.

Closes #3089

@JoeKar
Copy link
Collaborator Author

JoeKar commented Dec 12, 2023

@dustdfg
It doesn't took that long. Maybe you can have a look next time, if you can provide the solution directly as PR without creating a new issue. 😄

@dustdfg
Copy link
Contributor

dustdfg commented Dec 12, 2023

@dustdfg It doesn't took that long. Maybe you can have a look next time, if you can provide the solution directly as PR without creating a new issue. 😄

You are absolutely right... But I:

  1. Usually write spaghetti
  2. Didn't look at auto-completion before at all
  3. Didn't need it so bad
  4. Knew about PR (Reduce the available string option validators and add autocompletion for them #3021)

I knew that the PR will likely invalidate my PR (if I decide to write it) if it will be merged so I decided just to create issue without attempts to create PR and even looking on that part of code...

One note: I even didn't look at code of that PR but the name sounds like it can conflict

@JoeKar
Copy link
Collaborator Author

JoeKar commented Dec 12, 2023

One note: I even didn't look at code of that PR but the name sounds like it can conflict

Most probably OptionValueComplete() will need a small resolve, bu in general they don't really conflict each other, since #3021 tracks a specific kind of option predefined as list/choices. The filetype on the other hand is similar to the colorscheme, which uses stored filenames.

@zyedidia zyedidia merged commit e5a9b90 into zyedidia:master Jan 17, 2024
3 checks passed
@JoeKar JoeKar deleted the feature/autocomplete-filetypes branch January 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: autocomplete filetypes
3 participants