Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error loading modernx.lua with mpv v0.37.0-7 #6

Closed
Lovecraft-github opened this issue Nov 23, 2023 · 2 comments
Closed

error loading modernx.lua with mpv v0.37.0-7 #6

Lovecraft-github opened this issue Nov 23, 2023 · 2 comments

Comments

@Lovecraft-github
Copy link

Lovecraft-github commented Nov 23, 2023

With the latest mpv builds the modernx didn't load and return this message in console
modernx: modernx: stack traceback: modernx: /home/user/.config/mpv/scripts/modernx.lua:3269: in function 'visibility_mode' modernx: /home/user/.config/mpv/scripts/modernx.lua:2666: in function 'prop' modernx: mp.defaults:409: in function 'handler' modernx: mp.defaults:512: in function 'call_event_handlers' modernx: mp.defaults:554: in function 'dispatch_events' modernx: mp.defaults:505: in function <mp.defaults:504> modernx: [C]: in ? modernx: [C]: in ? modernx: Lua error: /home/user/.config/mpv/scripts/modernx.lua:3269: attempt to call field 'shared_script_property_set' (a nil value)

mpv v0.37.0-7-g86b498ecc0 Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects
built on Nov 22 2023 17:27:28
libplacebo version: v6.338.0-58-g2385b367
FFmpeg version: N-112826-g707e46dc54
FFmpeg library versions:
libavutil 58.32.100
libavcodec 60.34.100
libavformat 60.17.100
libswscale 7.6.100
libavfilter 9.13.100
libswresample 4.13.100

start happening after this commit
player: remove shared-script-properties property

@zydezu
Copy link
Owner

zydezu commented Nov 23, 2023

Does 4751dba fix this?

@Lovecraft-github
Copy link
Author

Yes it does

We can mark it closed, right?

Thank you

vioo-bkp added a commit to vioo-bkp/mpv-everforest that referenced this issue Aug 10, 2024
replace utils.shared_script_property_set("osc-visibility", mode)
with
mp.set_property_native("user-data/osc/visibility", mode)

source: zydezu/mpvconfig#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants