Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RSS14Reader #631

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+61 −55
Open

Clean up RSS14Reader #631

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7803c95
Fix thrown errors other than NotFoundException get lost in RSS14Reader
opl- Nov 23, 2024
02ab29e
Improve code correctness
opl- Nov 23, 2024
724d31f
findFinderPattern()[1] points the outside pixel of the finder pattern
opl- Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix thrown errors other than NotFoundException get lost in RSS14Reader
@opl-
opl- committed Dec 3, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
GPG key ID: F2548C2CBA04A848
Expired
Verified
Learn about vigilant mode
commit 7803c956effcf621eb9b5b6b23d42247167bbbc7
8 changes: 6 additions & 2 deletions src/core/oned/rss/RSS14Reader.ts
View file
Original file line number Diff line number Diff line change
@@ -141,8 +141,12 @@ export default class RSS14Reader extends AbstractRSSReader {
outside.getChecksumPortion() + 4 * inside.getChecksumPortion(),
pattern);
}
catch (err) {
return null;
catch (ex) {
if (ex instanceof NotFoundException) {
return null;
} else {
throw ex;
}
}
}