New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant tests for `ry` #183

Merged

jvdwetering merged 2 commits into zxcalc:master from dlyongemallo:remove_redundant_ry_test

Nov 20, 2023

Contributor

dlyongemallo commented Nov 18, 2023

These are already covered by the general qasm tests, except for reading from a file, which belongs in the qasm test file anyway.

In particular, test_to_qasm_and_back and test_ry_preserves_graph_semantics are both already covered by test_qasm_qiskit_semantics.

dlyongemallo added 2 commits

November 18, 2023 11:25


          Remove ry-specific tests as they are already covered by tests that co…

06e9598

…vers all qasm gates.


          Move test_load_qasm_from_file into test_qasm.py where it belongs.

351478b

jvdwetering merged commit c7454e9 into zxcalc:master

3 checks passed

dlyongemallo deleted the remove_redundant_ry_test branch

November 20, 2023 13:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet