Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Inclusion timeout should be more obvious #2079

Closed
kpine opened this issue Dec 19, 2021 · 0 comments · Fixed by #2747
Closed

[feat] Inclusion timeout should be more obvious #2079

kpine opened this issue Dec 19, 2021 · 0 comments · Fixed by #2747
Assignees
Labels
enhancement New feature or request

Comments

@kpine
Copy link
Contributor

kpine commented Dec 19, 2021

Is your feature request related to a problem? Please describe.
The inclusion dialog does not have a good indication that a timeout has occurred. It should be more obvious.

  • The countdown timer gets stuck at a non-zero time, I usually see it stop at 2 seconds
  • The flashing "spinner" at the top of the dialog continues to flash, as if something is happening
  • The dialog text says "Inclusion is started" even after it has stopped
  • The only way to exit is using the X button in the top right of the dialog

The only clues that it stopped are:

  • The "Inclusion Stopped" message is shown in the dimmed background, in the very small text area at the top
  • The "STOP" button just disappears

Both of those are very hard to notice unless you are paying close attention.

Describe the solution you'd like

  • An obvious message that the inclusion timed-out and was not successful
  • The timeout countdown to go down to zero, or just be removed when inclusion is finished
  • A button to close the dialog, such as "OK", which goes back to the initial inclusion dialog, the same as if you clicked the "STOP" button. Or just go there directly with a message that it timed out.
  • Optionally, a "RETRY" button to restart the inclusion with the same strategy, skipping the selection dialog.

Describe alternatives you've considered

Additional context

Screenshot of when the inclusion stops. It is just stuck in this state, with nothing obvious.

image

Just as a comparison, HA displays a message when it times out.

image

@kpine kpine added the enhancement New feature or request label Dec 19, 2021
robertsLando added a commit that referenced this issue Oct 21, 2022
robertsLando added a commit that referenced this issue Oct 21, 2022
- More obivious inclusion timeout. Fixes #2079
- Prevent hanging indeterminately when node added event is not trigger for some reason. Fixes #2746
- Disable go back while inclusion is running. Fixes #2735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants