Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] UI check for S2 keys is missing S2_AccessControl, checking S2_Authenticated twice #1896

Closed
3 tasks done
kpine opened this issue Oct 27, 2021 · 1 comment · Fixed by #1898
Closed
3 tasks done
Assignees
Labels
bug Something isn't working

Comments

@kpine
Copy link
Contributor

kpine commented Oct 27, 2021

Version

Checklist:

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Build/Run method

N/A, code inspection

Describe the bug

A user in HA discord reported a warning message about missing keys:

"Some security keys are missing: S2_Unauthenticated, S2_Authenticated, S2_Authenticated. Please check your zwave settings."

I noticed S2_Authenticated was repeated twice in the message and is missing S2_AccessControl. I noticed an array that defines the missing keys to check is defining S2_Authenticated twice; one of the S2_Authenticated should be S2_AccessControl.

https://github.com/zwave-js/zwavejs2mqtt/blob/23a5be6a7169dc42ab17b0f97f35152126b6e9ef/src/components/dialogs/DialogAddRemove.vue#L600-L605

To Reproduce

N/A

Expected behavior

Check for missing S2_AccessControl.

Additional context

None

@kpine kpine added the bug Something isn't working label Oct 27, 2021
@robertsLando
Copy link
Member

@kpine Thanks for spotting this bug, fix coming ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants