Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to ES Modules #2864

Closed
wants to merge 17 commits into from
Closed

build: migrate to ES Modules #2864

wants to merge 17 commits into from

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Jun 15, 2021

Update 2024-10-30:
This needs to be recreated anyways. We're going to aim for an ESM/CJS hybrid. One challenge is that ESM knows no require.resolve, but this can be polyfilled using ESBuild: evanw/esbuild#1633 (comment)


Old text

This PR is based on #3005 and makes node-zwave-js ready for ES Modules. The primary build output is now ESM, which is down-compiled to CommonJS in a postbuild step.

Blocked by:

@AlCalzone AlCalzone marked this pull request as draft June 15, 2021 15:00
@AlCalzone AlCalzone added breaking This is a breaking change infrastructure Issues related to infrastructure and development labels Jun 15, 2021
@AlCalzone AlCalzone marked this pull request as ready for review June 18, 2021 15:52
@AlCalzone AlCalzone marked this pull request as draft June 18, 2021 15:53
@AlCalzone AlCalzone changed the base branch from master to next July 5, 2021 13:11
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

1 similar comment
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change infrastructure Issues related to infrastructure and development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant