-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close button doesn't work #242
Labels
Comments
Thanks for the report! I'm already aware of the bug and will fix it ASAP. |
zvonicek
added a commit
that referenced
this issue
Apr 17, 2018
zvonicek
added a commit
that referenced
this issue
Apr 17, 2018
zvonicek
added a commit
that referenced
this issue
May 27, 2018
* Implement draft of customizable page indicator * Simplify PageIndicatorView page handling * Add target action for page indicator * Rework the page indicator positioning handling * Improve example project * Fix the full screen controller's close button (fixes #242) * Fix retain cycle bewteen ImageSlideshow and ZoomAnimatedTransitioning * Set swift_version to 4.0 * Set UIPageControl height to 30 * Fix underPadding behaviour * Improve page indicator backward compatibility * Split PageIndicator implementation to separate file * Set BG slideshow colour in example project to white * Improve safe area handing in page indicator * Update example project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems that 1.5.2 broke the close button when the slideshow is presented fullscreen. Please see attached video for reproduction steps
The text was updated successfully, but these errors were encountered: