UI: Emphasize column titles to differentiate it from regular texts. #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zee-bit
force-pushed
the
narrow-titles-bold
branch
3 times, most recently
from
9ab794e to
b0c3cf4
Compare
zee-bit
changed the title
This refactor renames the LIST_TITLE_BAR_LINE symbol to be more descriptive by replacing LIST with COLUMN. Since, the window of zulip-terminal is divided into 3 columns(stream/message/users) hence renaming to COLUMN seems more appropriate and intuitive.
This commit adds a new palette to themes for rendering column titles differently than regular text. This palette will be used in the subsequent commit to render the titles in bold so that they become consistent with the LineBox borders.
This commit passes a title_attribute to the LineBox widget for column titles which improves consistency with the surrounding LineBox borders and also helps in emphasizing the titles with respect to the text below.
zee-bit
force-pushed
the
narrow-titles-bold
branch
from
b0c3cf4 to
e3cdae1
Compare
zulipbot
added
size: M
|
@zee-bit Thanks for this UI adjustment - it's quite small but does make a difference 👍 I've just merged it with only small adjustments to the commit text for clarity 🎉 (generally we've ended up referring to each entry in a theme as a style) |
neiljp
added
area: UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor UI enhancement, that renders the column-titles in
boldto remain consistent with theLineBoxborders while differentiating them from the rest of the text.BEFORE:
monochrome
default
gruvbox
zt_light
zt_blue
AFTER:
monochrome
default
gruvbox
zt_light
zt_blue