tests: popups: Add type annotations. #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the passing of parameters in test definitions for parameters that are unused within the body of the test.
This commit refactors the multiple `dict` assignments to View classes' message attribute to Message instances instead to maintain type consistency.
This commit assigns the mocked keypress method of the emoji_picker_view within `test_mouse_event` of the TestEmojiPickerView class to a variable, so that the corresponding assert method calls are type consistent.
prah23
force-pushed
the
test_annotation_popups
branch
from
9c94d07 to
432819c
Compare
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
neiljp
added
the
PR awaiting update
prah23
removed
the
PR awaiting update
This was originally identified by prah23 <[email protected]>. This commit resolves the name conflict via a rename, rather than adjusting the autouse fixture to return an object which is explicitly used on demand (rather than being assigned to the fixture name).
This commit adds parameter and return type annotations or hints to the `test_popups.py` file, that contains tests for the corresponding classes present in `views.py` from the `zulipterminal` module, to make mypy checks consistent and improve code readability.
This commit adds `test_popups.py` to the `type_consistent_testfiles` list to check for type consistency with mypy.
neiljp
force-pushed
the
test_annotation_popups
branch
from
432819c to
eeecb67
Compare
|
@prah23 I think you actually found a bug with the test - compare the previous name of the autouse fixture and the attribute we assign! I made a simpler change than the fixture change you had previously and am going to merge that with your other commits shortly 🎉 I'm looking forward to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds type annotations to
test_popups.pyand adds the file to the list inrun-mypy. Also has a few related prior refactors to ensure type consistency.Tested?
Commit flow
refactor: tests: popups: Remove unnecessary parameters.
This commit removes the passing of parameters in test definitions
for parameters that are unused within the body of the test.
refactor: tests: popups: Use Message instances to pass into views.
This commit refactors the multiple
dictassignments to View classes'message attribute to Message instances instead to maintain type
consistency.
refactor: tests: popups: Assign mocked keypress to a variable.
This commit assigns the mocked keypress method of the
emoji_picker_view within
test_mouse_eventof the TestEmojiPickerViewclass to a variable, so that the corresponding assert method calls
are type consistent.
refactor: tests: popups: Return a PopUpView instance from pop_up_view.
This commit refactors the pop_up_view fixture to return a PopUpView
instance for usage in further tests, instead of assigning the instance
to an attribute of the TestPopUpView class, to maintain type
consistency.
refactor: tests: popups: Add type annotations.
This commit adds parameter and return type annotations or hints
to the
test_popups.pyfile, that contains tests for thecorresponding classes present in
views.pyfrom thezulipterminalmodule, to make mypy checks consistent andimprove code readability.
tools: Include test_popups.py to be checked by mypy.
This commit adds
test_popups.pyto thetype_consistent_testfileslist to check for type consistency with mypy.