bugfix: boxes/ui: Display mouse selection_hint for entire View.
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes 2 bugs related to displaying selection_hint on mouse_drag events. This migrates the mouse_event from MessageBox to the entire View so that the selection_hint is displayed even when the user tries to perform mouse_drag events outside of MessageBox i.e. anywhere in View. This also fixes selection_hint getting stuck in the footer if the mouse is dragged in the MessageView but released outside of it.
neiljp
added
area: UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit fixes 2 bugs related to displaying selection_hint on mouse_drag
events. This migrates the mouse_event from MessageBox to the entire View
so that the selection_hint is displayed even when the user tries to perform
mouse_drag events outside of MessageBox i.e. anywhere in View.
This also fixes selection_hint getting stuck in the footer if the mouse is
dragged in the MessageView but released outside of it.
Thanks to @Rohitth007 for reporting this bug in #zulip terminal>Drag-to-select-text
Tested?