popup: core: Use linear scaling for small terminal sizes. #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zulipbot add "PR needs review" |
neiljp
reviewed
May 1, 2021
There was a problem hiding this comment.
@Rohitth007 See my feedback in the stream, but I'm essentially interested in whether we should scale the height based on the width, or treat it differently based on another rule.
neiljp
added
feedback wanted
and removed
PR needs review
Rohitth007
force-pushed
the
popup-scale
branch
4 times, most recently
from
bddcdbf to
c3dc4e8
Compare
This commit is a contribution towards zulip#1005, allowing popups such as the help menu to show properly on an 80-column width terminal. This changes the fixed scaling factor of 3/4 to one that is linear in the range 80 - 100 column width: * The scaling fraction increases from 3/4 to 1 (full-width) as the available size increases from 80 to 100. This increases the range of sizes for which the popup is rendered properly. * For width's smaller than 80 it defaults to full width. * For width's greater than 100 it defaults to 3/4. The values 80 and 100 are given by: * MIN_SUPPORTED_POPUP_WIDTH = 80 * MAX_LINEAR_SCALING_WIDTH = 100 The popup height has a fixed scaling factor of 3/4, which retains visibility of the title when the window is at the minimum supported height. Tests added.
|
@Rohitth007 Adjusted comment and expressions for clarity, and commit text slightly, and just merged 🎉 |
7 tasks
neiljp
added
area: UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a step towards solving #1005 especially the first
2 points. This changes the fixed scaling fraction of 3/4 to one that
is linear in the range 80 - 100 column width:
available size increases from 80 to 100. This increases the range of
sizes for which the popup is rendered properly.
The values 80 and 100 are given by:
The popup height has a fixed scaling factor of 2/3.
Tests added
80 < Width < 100
Width = 80
Width > 100 (Full screen)