Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstarred messages from starred messages narrow #940

Closed
mkp6781 opened this issue Mar 4, 2021 · 4 comments
Closed

Remove unstarred messages from starred messages narrow #940

mkp6781 opened this issue Mar 4, 2021 · 4 comments
Assignees
@Abhirup-99
Labels
bug Something isn't working in progress
Milestone
0.7.0

Comments

@mkp6781
Copy link
Contributor

mkp6781 commented Mar 4, 2021

Steps to reproduce:

  1. Star a message. You can find it added to the starred messages narrow.
  2. Now unstar it. The star in the top right corner is no longer visible but the message can still be seen in the starred messages narrow.

This is the case only within the same ZT session. As per the behaviour in the webapp, unstarred messages should be removed from starred messages narrow immediately.
@mkp6781 mkp6781 changed the title Remove unstarred messages from starred messages narrow Remove unstarred messages from starred messages narrow Mar 4, 2021
@Abhirup-99
Copy link
Contributor

Can I take this up?

@Abhirup-99
Copy link
Contributor

@zulipbot claim.

@zulipbot
Copy link
Member

zulipbot commented Mar 4, 2021

Hello @Abhirup-99!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@mkp6781
Copy link
Contributor Author

mkp6781 commented Mar 4, 2021

Can I take this up?

Yes you can go ahead. 👍🏼

Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 6, 2021
@Abhirup-99
starredmessages: Remove message when moving out of starred section.
b7752ed 
The commit updates ZT behavior in starred message section
to match the web app. The current behavior involves removing
the message when the user moves out of the starred section.
Fixes zulip#940.
@Abhirup-99 Abhirup-99 mentioned this issue Mar 6, 2021
Closed
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 6, 2021
@Abhirup-99
starredmessages: Remove message when moving out of starred section.
1cbfdf3 
The commit updates ZT behavior in starred message section
to match the web app. The current behavior involves removing
the message when the user moves out of the starred section.
Fixes zulip#940.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 6, 2021
@Abhirup-99
starredmessages: Remove message when moving out of starred section.
6e87c8d 
The commit updates ZT behavior in starred message section
to match the web app. The current behavior involves removing
the message when the user moves out of the starred section.
Fixes zulip#940.
Abhirup-99 pushed a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 8, 2021
@Abhirup-2019
bugfix: starred_messages: Update messages in starred narrow.
a91a2fa 
The commit updates ZT behavior in starred message section
to match the web app. The current behavior involves removing
the message when the user moves out of the starred section.
Fixes zulip#940.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 8, 2021
@Abhirup-99
bugfix: starred_messages: Update messages in starred narrow.
e9930ad 
The commit updates ZT behavior in starred message section
to match the web app. The current behavior involves removing
the message when the user moves out of the starred section.
Fixes zulip#940.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 8, 2021
@Abhirup-99
bugfix: starred_messages: Update messages in starred narrow.
55df59e 
The commit updates ZT behavior in starred message section
to match the web app. The current behavior involves removing
the message when the user moves out of the starred section.
Fixes zulip#940.
Abhirup-99 added a commit to Abhirup-99/zulip-terminal that referenced this issue Mar 10, 2021
@Abhirup-99
bugfix: starred_messages: Update messages in starred narrow.
f0b114c 
* Handle starred message addition and removal
events.
* Fix race around condition to handle removal of
last loaded message in the starred narrow without
exceptions.
Tests updated.
Fixes zulip#940.
@neiljp neiljp closed this as completed in 53a6c03 Mar 15, 2021
@neiljp neiljp added this to the Next Release milestone Mar 15, 2021
@neiljp neiljp added the bug Something isn't working label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhirup-99 Abhirup-99

Labels
bug Something isn't working in progress
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

bugfix: starred messages: Update messages in starred narrow. Abhirup-99/zulip-terminal
4 participants
@neiljp @zulipbot @Abhirup-99 @mkp6781