boxes/themes: Add styles to math (KaTeX) text for different themes.

Tests amended.
zulip · Jul 6, 2021 · bee39b8 · bee39b8
1 parent b267ac1
commit bee39b8
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 3 deletions.
diff --git a/tests/ui/test_ui_tools.py b/tests/ui/test_ui_tools.py
@@ -1734,15 +1734,15 @@ def test_private_message_to_self(self, mocker):
                 # ```
                 '<span class="katex-display"><span class="katex"><semantics>'
                 "<annotation>some-math</annotation></semantics></span></span>",
-                ["some-math"],
+                [("msg_math", "some-math")],
                 id="katex_HTML_response_math_fenced_markdown",
             ),
             case(
                 # Markdown:
                 # $$ some-math $$
                 '<span class="katex"><semantics><annotation>some-math</annotation>'
                 "</semantics></span>",
-                ["some-math"],
+                [("msg_math", "some-math")],
                 id="katex_HTML_response_double_$_fenced_markdown",
             ),
             case("<ul><li>text</li></ul>", ["", "  \N{BULLET} ", "", "text"], id="ul"),

diff --git a/zulipterminal/config/themes.py b/zulipterminal/config/themes.py
@@ -36,6 +36,7 @@
     'msg_emoji'       : 'bold',
     'reaction'        : 'bold',
     'reaction_mine'   : 'standout',
+    'msg_math'        : 'standout',
     'msg_mention'     : 'bold',
     'msg_link'        : '',
     'msg_link_index'  : 'bold',

diff --git a/zulipterminal/themes/gruvbox.py b/zulipterminal/themes/gruvbox.py
@@ -56,6 +56,7 @@ class GruvBoxColor(Enum):
     'msg_emoji'        : (Color.NEUTRAL_PURPLE,        Color.DARK0_HARD),
     'reaction'         : (Color.NEUTRAL_PURPLE__BOLD,  Color.DARK0_HARD),
     'reaction_mine'    : (Color.DARK0_HARD,            Color.NEUTRAL_PURPLE),
+    'msg_math'         : (Color.DARK0_HARD,            Color.GRAY_244),
     'msg_mention'      : (Color.BRIGHT_RED__BOLD,      Color.DARK0_HARD),
     'msg_link'         : (Color.BRIGHT_BLUE,           Color.DARK0_HARD),
     'msg_link_index'   : (Color.BRIGHT_BLUE__BOLD,     Color.DARK0_HARD),

diff --git a/zulipterminal/themes/zt_blue.py b/zulipterminal/themes/zt_blue.py
@@ -30,6 +30,7 @@
     'msg_emoji'       : (Color.DARK_MAGENTA,        Color.LIGHT_BLUE),
     'reaction'        : (Color.DARK_MAGENTA__BOLD,  Color.LIGHT_BLUE),
     'reaction_mine'   : (Color.LIGHT_BLUE,          Color.DARK_MAGENTA),
+    'msg_math'        : (Color.LIGHT_GRAY,          Color.DARK_GRAY),
     'msg_mention'     : (Color.LIGHT_RED__BOLD,     Color.LIGHT_BLUE),
     'msg_link'        : (Color.DARK_BLUE,           Color.LIGHT_GRAY),
     'msg_link_index'  : (Color.DARK_BLUE__BOLD,     Color.LIGHT_GRAY),

diff --git a/zulipterminal/themes/zt_dark.py b/zulipterminal/themes/zt_dark.py
@@ -30,6 +30,7 @@
     'msg_emoji'       : (Color.LIGHT_MAGENTA,       Color.BLACK),
     'reaction'        : (Color.LIGHT_MAGENTA__BOLD, Color.BLACK),
     'reaction_mine'   : (Color.BLACK,               Color.LIGHT_MAGENTA),
+    'msg_math'        : (Color.LIGHT_GRAY,          Color.DARK_GRAY),
     'msg_mention'     : (Color.LIGHT_RED__BOLD,     Color.BLACK),
     'msg_link'        : (Color.LIGHT_BLUE,          Color.BLACK),
     'msg_link_index'  : (Color.LIGHT_BLUE__BOLD,    Color.BLACK),

diff --git a/zulipterminal/themes/zt_light.py b/zulipterminal/themes/zt_light.py
@@ -30,6 +30,7 @@
     'msg_emoji'       : (Color.LIGHT_MAGENTA,       Color.WHITE),
     'reaction'        : (Color.LIGHT_MAGENTA__BOLD, Color.WHITE),
     'reaction_mine'   : (Color.WHITE,               Color.LIGHT_MAGENTA),
+    'msg_math'        : (Color.DARK_GRAY,           Color.LIGHT_GRAY),
     'msg_mention'     : (Color.LIGHT_RED__BOLD,     Color.WHITE),
     'msg_link'        : (Color.DARK_BLUE,           Color.WHITE),
     'msg_link_index'  : (Color.DARK_BLUE__BOLD,     Color.WHITE),

diff --git a/zulipterminal/ui_tools/boxes.py b/zulipterminal/ui_tools/boxes.py
@@ -1121,7 +1121,7 @@ def soup2markup(
                 if element.find("annotation"):
                     tag_text = element.find("annotation").text
 
-                markup.append(tag_text)
+                markup.append(("msg_math", tag_text))
             elif tag == "span" and (
                 {"user-group-mention", "user-mention"} & set(tag_classes)
             ):