deps: Remove expo-splash-screen. #4937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empirically, this is no longer needed: we added it in c4fca9d to satisfy a peer-dependency constraint, but now I'm not getting a peer-dep warning if I remove it. See zulip#4279 and discussion at https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/React.20Navigation.20v5/near/1042787 for some warnings from Greg about the design of expo-splash-screen, should we choose to actually use it one day.
|
Closing as superseded by #4949. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empirically, this is no longer needed: we added it in c4fca9d to
satisfy a peer-dependency constraint, but now I'm not getting a
peer-dep warning if I remove it.
See #4279 and discussion at
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/React.20Navigation.20v5/near/1042787
for some warnings from Greg about the design of expo-splash-screen,
should we choose to actually use it one day.