Removed react-native-text-input-reset dependency
#4243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey , @chrisbobbe Is there something I am missing out? |
|
Hi, sorry for the delay! I haven't yet gotten around to reviewing this, but I'll try to take a look soon. Thanks for the PR! 🙂 |
|
Thanks @aryanshridhar for sending this! After the investigation starting at #4239 (comment) , I ended up doing this a different way -- the workaround is no longer necessary in the first place, so we can drop the dependency without incorporating its code into our tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all ,
This is a fix for #4239 i.e to remove react-native-text-input-reset dependency ( as it may get deprecated ) by adding a custom native module .
Would love an review for the same :)