Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: normalize case of realm_uri and account.realm #3671

Closed
wants to merge 1 commit into from
Closed

notifications: normalize case of realm_uri and account.realm #3671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/notification/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,18 @@ export const getAccountFromNotificationData = (
return null;
}

// The `realm_uri` we get from the server should be case-normalized already;
// but better safe than sorry.
const normalized_realm_uri = realm_uri.toLowerCase();
const urlMatches = [];
identities.forEach((account, i) => {
if (account.realm === realm_uri) {
// `account.realm` is _not_ case-normalized; it's straight from user input,
// which (judging from error reports) autocorrect seems to be forcibly
// autocapitalizing on some devices.
//
// (TODO: instead of performing case-mangling, just compare against the
// value of `realm_uri` we get from `/server_settings` at login time.)
if (account.realm.toLowerCase() === normalized_realm_uri) {
urlMatches.push(i);
}
});
Expand Down