Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Native 0.56 & 0.57 #2789

Merged
merged 7 commits into from
Nov 1, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: Add fixmes for a few issues the RN/Flow upgrade turns up.
Without this change, after the upcoming upgrades Flow gives error
messages here.  If I understand the error messages correctly (though
I'm not confident I do), the point is that these particular components
insist on their props being read-only -- and while ViewStyleProp and
friends make that guarantee, DangerouslyImpreciseStyleProp doesn't.

These will be resolved properly when we eventually go about and narrow
down uses of DangerouslyImpreciseStyleProp to the more specific types.
Until then, just leave these fixmes.
gnprice committed Oct 31, 2018
commit cc64ebec68b3bcbee9613f93fadca36888d10c59
2 changes: 1 addition & 1 deletion src/common/KeyboardAvoider.js
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ export default class KeyboardAvoider extends PureComponent<Props> {

return (
<KeyboardAvoidingView
behavior={behavior}
behavior={behavior /* v--- $FlowFixMe wants ViewStyleProp */}
contentContainerStyle={contentContainerStyle}
style={style}
>
5 changes: 4 additions & 1 deletion src/common/Screen.js
Original file line number Diff line number Diff line change
@@ -112,7 +112,10 @@ class Screen extends PureComponent<Props> {
>
{scrollableContent ? (
<ScrollView
contentContainerStyle={[centerContent && componentStyles.content, style]}
contentContainerStyle={
/* $FlowFixMe wants ViewStyleProp */
[centerContent && componentStyles.content, style]
}
style={componentStyles.childrenWrapper}
keyboardShouldPersistTaps={keyboardShouldPersistTaps}
>
2 changes: 1 addition & 1 deletion src/common/Touchable.js
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ export default class Touchable extends PureComponent<Props> {
return (
<TouchableHighlight
accessibilityLabel={accessibilityLabel}
underlayColor={HIGHLIGHT_COLOR}
underlayColor={HIGHLIGHT_COLOR /* v--- $FlowFixMe wants ViewStyleProp */}
style={style}
onPress={onPress}
onLongPress={onLongPress}