Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On reaction events use user_id, instead of old user object #5911

Closed
gnprice opened this issue Jan 10, 2025 · 0 comments · Fixed by #5912
Closed

On reaction events use user_id, instead of old user object #5911

gnprice opened this issue Jan 10, 2025 · 0 comments · Fixed by #5912
Assignees
@chrisbobbe
Labels
api migrations P1 high-priority

Comments

@gnprice
Copy link
Member

gnprice commented Jan 10, 2025

This is a follow-up to:

In that round we switched how we process the reactions that come inside message objects. But in the server API, a similar transition also happened in reaction events. We should follow the transition there too.

This is a change it's useful to go ahead and make in this legacy app, because that will hasten the day when we can drop the user objects from reactions on the server, and because it should be a small change to make.

References
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 11, 2025
@chrisbobbe
api: On reaction events, stop assuming old user object is present
f24cc47 
The `user_id` field has been present in reaction events since Zulip
3.0 (FL 2), which is below our kMinAllowedServerVersion (4.0). See
API docs:
  https://zulip.com/api/get-events#reaction-add
  https://zulip.com/api/get-events#reaction-remove

Fixes: zulip#5911
@chrisbobbe chrisbobbe mentioned this issue Jan 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
api migrations P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: On reaction events, stop assuming old user object is present chrisbobbe/zulip-mobile
2 participants
@gnprice @chrisbobbe