Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ESLint 7. #4253

Closed
chrisbobbe opened this issue Sep 10, 2020 · 1 comment · Fixed by #4327
Closed

Upgrade to ESLint 7. #4253

chrisbobbe opened this issue Sep 10, 2020 · 1 comment · Fixed by #4327
Labels
a-tools dependencies Pull requests that update a dependency file

Comments

@chrisbobbe
Copy link
Contributor

Filing this quickly as a placeholder so we have something to refer to.

Currently, this is known to be blocked by prettier-eslint not supporting ESLint 7 yet: prettier/prettier-eslint#401.
@chrisbobbe chrisbobbe added a-tools dependencies Pull requests that update a dependency file labels Sep 10, 2020
@chrisbobbe chrisbobbe mentioned this issue Sep 10, 2020
Closed
@chrisbobbe chrisbobbe added the blocked on other work To come back to after another related PR, or some other task. label Sep 15, 2020
@chrisbobbe
Copy link
Contributor Author

Version 12.0.0 of prettier-eslint reportedly just got ESLint 7 support, so I'm unblocking this! 🎉

@chrisbobbe chrisbobbe removed the blocked on other work To come back to after another related PR, or some other task. label Nov 21, 2020
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Dec 4, 2020
@chrisbobbe
deps: Upgrade ESLint-related deps to their latest.
00a9290 
Done with

```
yarn upgrade --latest $(tools/test deps | grep eslint)
```

which was easier than 01593b3.

One thing we neglected to mention in 01593b3, which still applies
here, is that the version of ESLint used by `prettier-eslint-cli` is
still 5, and it's unclear when (or if) that'll change [1], which is
unfortunate.

[1] prettier/prettier-eslint-cli#304

Fixes: zulip#4253
@chrisbobbe chrisbobbe mentioned this issue Dec 4, 2020
Merged
@gnprice gnprice closed this as completed in b6546e9 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-tools dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Upgrade ESLint-related deps to their latest. chrisbobbe/zulip-mobile
1 participant
@chrisbobbe