Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide UI to update own profile #3372

Open
borisyankov opened this issue Feb 27, 2019 · 16 comments
Open

Provide UI to update own profile #3372

borisyankov opened this issue Feb 27, 2019 · 16 comments
Labels
blocked on other work To come back to after another related PR, or some other task.

Comments

@borisyankov
Copy link
Contributor

borisyankov commented Feb 27, 2019

Implement the functionality that exists on the web at:
https://chat.zulip.org/#settings/your-account

Important:

  • Email, Full name, Password
  • Upload new avatar

Secondary:

  • Deactivate account
  • Custom profile fields
@anh2111htd
Copy link
Collaborator

@zulipbot claim

@AdityaHirapara
Copy link
Contributor

I would like to work on this issue

@AdityaHirapara
Copy link
Contributor

AdityaHirapara commented Mar 18, 2019

I am thinking of implementing it on profile tab like this, then pressing button will navigate to new screen like user status.
Screenshot_2019-03-18-19-20-50-35

@borisyankov any suggestions?

@borisyankov
Copy link
Contributor Author

@AdityaHirapara we have some problems with vertical space here - some phone screens might not be high enough to fit this. I have an idea for a different style of 'Edit profile' button, but it is perfectly fine to start working on this with this implementation and we can fix that before merging it.

@timabbott
Copy link
Member

We probably don't need to show local time for your own profile, so there may be some space optimization options available too.

@AdityaHirapara
Copy link
Contributor

We probably don't need to show local time for your own profile, so there may be some space optimization options available too.

Yes, That can be done.

@borisyankov
Copy link
Contributor Author

We probably need this information somewhere though.
If there is a timezone set it is not necessarily what the actual time of the device is.

Also, I haven't had set this for myself so my concern for the space was even without that line.

@anh2111htd
Copy link
Collaborator

Hi @AdityaHirapara, I've already been working on this issue :) I claimed 2 weeks ago but didn't update frequently as it took a while to learn the codebase and debug.

For now, user can edit their own full name, I'm working on allowing them to edit avatar and password. @borisyankov can you help me do a quick review for #3421 as it may relate to your PR #3403?

@AdityaHirapara
Copy link
Contributor

Oh okay, Let me know if I can help you with anything :)

@timabbott
Copy link
Member

We should be sure to disable the widget when changing a user's avatar is disabled (see zulip/zulip#12251) because the organization is syncing them from LDAP.

@borisyankov
Copy link
Contributor Author

borisyankov commented May 3, 2019

@timabbott should we introduce a capabilities or permissions object with flags on register?
The purpose will be to move the biz logic of determining what the client can do to the back-end.

So stuff like:

  • if ldap enabled => canEditProfile: false
  • if user is admin => canDeleteStream: true
  • etc.

@timabbott
Copy link
Member

timabbott commented May 3, 2019 via email

@gnprice gnprice changed the title Allow updating own profile Provide UI to update own profile Jan 7, 2020
@chrisbobbe
Copy link
Contributor

We've had another report of this, here.

@gnprice gnprice added help wanted blocked on other work To come back to after another related PR, or some other task. and removed help wanted labels Mar 3, 2021
@gnprice
Copy link
Member

gnprice commented Mar 3, 2021

This will require #3397 and some other parts of #3408 -- when we get an update to this information from the server, we'll need to apply it.

@chrisbobbe
Copy link
Contributor

In particular, I think, we'd want to get #5208 done, or else this will seem like a buggy experience, I think.

We've just had another report of this in a Play Store review: https://chat.zulip.org/#narrow/stream/48-mobile/topic/appfollow/near/1413737

@gnprice
Copy link
Member

gnprice commented Sep 5, 2024

This came up a couple of times recently. Both were specifically about setting the avatar:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked on other work To come back to after another related PR, or some other task.
Projects
None yet
Development

No branches or pull requests

6 participants