Provide UI to update own profile

[borisyankov]

Implement the functionality that exists on the web at:
https://chat.zulip.org/#settings/your-account

Important:

• Email, Full name, Password
• Upload new avatar

Secondary:

• Deactivate account
• Custom profile fields

[anh2111htd]

@zulipbot claim

[AdityaHirapara]

I would like to work on this issue

[AdityaHirapara]

I am thinking of implementing it on profile tab like this, then pressing button will navigate to new screen like user status.

@borisyankov any suggestions?

[borisyankov]

@AdityaHirapara we have some problems with vertical space here - some phone screens might not be high enough to fit this. I have an idea for a different style of 'Edit profile' button, but it is perfectly fine to start working on this with this implementation and we can fix that before merging it.

[timabbott]

We probably don't need to show local time for your own profile, so there may be some space optimization options available too.

[AdityaHirapara]

We probably don't need to show local time for your own profile, so there may be some space optimization options available too.

Yes, That can be done.

[borisyankov]

We probably need this information somewhere though.
If there is a timezone set it is not necessarily what the actual time of the device is.

Also, I haven't had set this for myself so my concern for the space was even without that line.

[anh2111htd]

Hi @AdityaHirapara, I've already been working on this issue :) I claimed 2 weeks ago but didn't update frequently as it took a while to learn the codebase and debug.

For now, user can edit their own full name, I'm working on allowing them to edit avatar and password. @borisyankov can you help me do a quick review for #3421 as it may relate to your PR #3403?

[AdityaHirapara]

Oh okay, Let me know if I can help you with anything :)

[timabbott]

We should be sure to disable the widget when changing a user's avatar is disabled (see zulip/zulip#12251) because the organization is syncing them from LDAP.

[borisyankov]

@timabbott should we introduce a capabilities or permissions object with flags on register?
The purpose will be to move the biz logic of determining what the client can do to the back-end.

So stuff like:

• if ldap enabled => canEditProfile: false
• if user is admin => canDeleteStream: true
• etc.

[timabbott]

In this case, it is unnecessary... you can just check for the keys in the register response, using false (not disabled) as the default if not present

…

-Tim Abbott (mobile)

On Fri, May 3, 2019, 3:28 PM Boris Yankov ***@***.***> wrote: @timabbott <https://github.com/timabbott> should we introduce a capabilities or permissions object with flags on register? The purpose will be to move the biz logic of determining what the client can do to the back-end. So stuff like 'if ldap => canEditProfile: false, if admin => canDeleteStream: false` etc. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3372 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAU6NWVSDUTEXWJR5VVMOCDPTS4CTANCNFSM4G2ULMQQ> .

[chrisbobbe]

We've had another report of this, here.

[gnprice]

This will require #3397 and some other parts of #3408 -- when we get an update to this information from the server, we'll need to apply it.

[chrisbobbe]

In particular, I think, we'd want to get #5208 done, or else this will seem like a buggy experience, I think.

We've just had another report of this in a Play Store review: https://chat.zulip.org/#narrow/stream/48-mobile/topic/appfollow/near/1413737

[gnprice]

This came up a couple of times recently. Both were specifically about setting the avatar:

• in 2024-06: https://chat.zulip.org/#narrow/stream/137-feedback/topic/Favorite.20editor/near/1836540
• and in 2024-08 indirectly: https://chat.zulip.org/#narrow/stream/137-feedback/topic/The.203.20top.20features.20of.20your.20dreams/near/1926811 (though I think in that case having this feature wouldn't have solved the user's needs — they'd still want to set the avatar for all users in their realm up front using the API)