-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide UI to update own profile #3372
Comments
@zulipbot claim |
I would like to work on this issue |
I am thinking of implementing it on profile tab like this, then pressing button will navigate to new screen like user status. @borisyankov any suggestions? |
@AdityaHirapara we have some problems with vertical space here - some phone screens might not be high enough to fit this. I have an idea for a different style of 'Edit profile' button, but it is perfectly fine to start working on this with this implementation and we can fix that before merging it. |
We probably don't need to show local time for your own profile, so there may be some space optimization options available too. |
Yes, That can be done. |
We probably need this information somewhere though. Also, I haven't had set this for myself so my concern for the space was even without that line. |
Hi @AdityaHirapara, I've already been working on this issue :) I claimed 2 weeks ago but didn't update frequently as it took a while to learn the codebase and debug. For now, user can edit their own full name, I'm working on allowing them to edit avatar and password. @borisyankov can you help me do a quick review for #3421 as it may relate to your PR #3403? |
Oh okay, Let me know if I can help you with anything :) |
We should be sure to disable the widget when changing a user's avatar is disabled (see zulip/zulip#12251) because the organization is syncing them from LDAP. |
@timabbott should we introduce a So stuff like:
|
In this case, it is unnecessary... you can just check for the keys in the
register response, using false (not disabled) as the default if not present
…-Tim Abbott (mobile)
On Fri, May 3, 2019, 3:28 PM Boris Yankov ***@***.***> wrote:
@timabbott <https://github.com/timabbott> should we introduce a
capabilities or permissions object with flags on register?
The purpose will be to move the biz logic of determining what the client
can do to the back-end.
So stuff like 'if ldap => canEditProfile: false, if admin =>
canDeleteStream: false` etc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3372 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAU6NWVSDUTEXWJR5VVMOCDPTS4CTANCNFSM4G2ULMQQ>
.
|
We've had another report of this, here. |
In particular, I think, we'd want to get #5208 done, or else this will seem like a buggy experience, I think. We've just had another report of this in a Play Store review: https://chat.zulip.org/#narrow/stream/48-mobile/topic/appfollow/near/1413737 |
This came up a couple of times recently. Both were specifically about setting the avatar:
|
Implement the functionality that exists on the web at:
https://chat.zulip.org/#settings/your-account
Important:
Secondary:
The text was updated successfully, but these errors were encountered: